moodlehq / moodle-cs

Moodle Coding Style
https://github.com/moodlehq/moodle-cs
GNU General Public License v3.0
18 stars 15 forks source link

Ignore invalid method names using the Override attribute #170

Closed andrewnicols closed 2 months ago

andrewnicols commented 2 months ago

This is useful where we must override methods in third-party libraries.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.11%. Comparing base (44ad668) to head (48f8099).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #170 +/- ## ============================================ + Coverage 98.09% 98.11% +0.02% - Complexity 935 947 +12 ============================================ Files 40 40 Lines 2777 2807 +30 ============================================ + Hits 2724 2754 +30 Misses 53 53 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

andrewnicols commented 2 months ago

Huzzah. Good catches on those. I wrote this about 10 minutes before you did the last release and screwed up the rebase.

stronk7 commented 2 months ago

Here we go! 🚀