search

moodlehq / moodle-cs

Moodle Coding Style
https://github.com/moodlehq/moodle-cs
GNU General Public License v3.0
18 stars 16 forks source link

Avoid abstract infinite loop #94

Closed stronk7 closed 10 months ago

stronk7 commented 10 months ago

Fix a couple of Sniffs that were able to enter into an infinite loop when processing test_xxx abstract methods.

Also adds a change to previous guard against that, because it was causing the abstract methods not to be processed.

Covered with tests.

Fixes #93

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (de2bd4d) 96.59% compared to head (6ffdc32) 96.58%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #94 +/- ## ============================================ - Coverage 96.59% 96.58% -0.01% + Complexity 537 536 -1 ============================================ Files 23 23 Lines 1525 1521 -4 ============================================ - Hits 1473 1469 -4 Misses 52 52 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

stronk7 commented 10 months ago

I'm self-merging this towards a round of releases soon.