moodlehq / moodle-cs

Moodle Coding Style
https://github.com/moodlehq/moodle-cs
GNU General Public License v3.0
18 stars 16 forks source link

Allow comments followed by an attribute #96

Closed andrewnicols closed 9 months ago

andrewnicols commented 9 months ago

Per PER-2.0:

If a comment docblock is present on a structure that also includes an attribute, the comment block MUST come first, followed by any attributes, followed by the structure itself. There MUST NOT be any blank lines between the docblock and attributes, or the attributes and the structure.

https://www.php-fig.org/per/coding-style/#122-placement

Other more attribute-specific Sniffs should test for Attributes and their correctness, but this comment sniff should not add false positives.

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (9f0b0c1) 96.59% compared to head (5b915e4) 96.61%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #96 +/- ## ============================================ + Coverage 96.59% 96.61% +0.01% - Complexity 536 537 +1 ============================================ Files 23 23 Lines 1527 1536 +9 ============================================ + Hits 1475 1484 +9 Misses 52 52 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.