Login in dockerhub when possible to avoid pull limits

moodlehq / moodle-docker

A docker environment for moodle developers

GNU General Public License v3.0

406 stars 252 forks source link

Login in dockerhub when possible to avoid pull limits #150

Closed stronk7 closed 3 years ago

stronk7 commented 3 years ago

With current pull limits @ dockerhub, it's possible to get failed jobs just running 2-3 builds (each one having a good number of jobs).

With this patch, if both DOCKER_USER and DOCKER_TOKEN are defined as environmental variables, they will be used to perform a login to dockerhub, getting rid of pull limits.

stronk7 commented 3 years ago

Please, do not merge this yet, it's WIP stuff (I just needed to make the PR to verify the dockerhub credentials are working as expected).

stronk7 commented 3 years ago

It's passing ok:

Not authenticated: https://travis-ci.com/github/moodlehq/moodle-docker/jobs/472347956 , with logged text: Using unauthenticated docker (pull limits may apply). Setup DOCKER_USER and DOCKER_TOKEN if needed.
Authenticated: https://travis-ci.com/github/stronk7/moodle-docker/jobs/472347953 , with logged text: Using authenticated connection (no pull limits) So everything working as expected, preparing the final patch and merging this once it passes...