moodlehq / moodle-docker

A docker environment for moodle developers
GNU General Public License v3.0
376 stars 245 forks source link

Add GHA support to moodle-docker #159

Closed stronk7 closed 3 years ago

stronk7 commented 3 years ago

Basically does the same than old Travis runs, with some differences:

stronk7 commented 3 years ago

You can see it passing @ https://github.com/stronk7/moodle-docker/actions/runs/849100015

And the very-last commit (36fe4b0) that makes this PR is running @ https://github.com/stronk7/moodle-docker/actions/runs/849335063

Ciao :-)

PS: Obviously... this PR only can run Travis tests, because GHA is not upstream, heh. ;-)

stronk7 commented 3 years ago

Have amended the commit (4ce009b) to save setting up one variable... latest changes are being run now by Travis and https://github.com/stronk7/moodle-docker/actions/runs/849537749.

Ciao :-)

vmdef commented 3 years ago

Thank you @stronk7. The structure is quite clear and the comment makes it even easier to understand the code. Only one minor typo that does not "matter".

stronk7 commented 3 years ago

minor typo that does not "matter".

Whops, will try to fix it on next PR, thanks!