search

moodlehq / moodle-docker

A docker environment for moodle developers
GNU General Public License v3.0
376 stars 245 forks source link

Update README.md due Xdebug 2 to 3 upgrade #163

Closed adpe closed 3 years ago

adpe commented 3 years ago

https://xdebug.org/docs/upgrade_guide

PR result of this message https://t.me/moodledev/90141

image

stronk7 commented 3 years ago

Just cross-linking to #146 because in that issue there were some extra config settings that we may want to have documented, feel free to discuss about anything here.

Ciao :-)

djhipps commented 3 years ago

I have reviewed the above and confirm that

read -r -d '' conf <<'EOF' ; Settings for Xdebug Docker configuration xdebug.mode=debug xdebug.client_host=host.docker.internal xdebug.idekey=VSCODE EOF

is suffient for me and some of the settings in #146 were superflous.

stronk7 commented 3 years ago

So, the idekey is needed, correct? Or am I wrong and it's not needed?

Maybe it's the IDE the one requiring it? For example, I remember myself playing with it with vim and I think it was not needed (in fact I don't have it defined in my php.ini files.

What about adding it commented out, sort of:

; Some IDEs (list, of, ides, known, to, require, it...) may require to configure an idekey, uncomment if needed
; xdebug.idekey=MY_FAV_IDE_KEY

Ciao :-)

stronk7 commented 3 years ago

And merged, thanks!