Deprecated MOODLE_APP_VERSION variable not properly handled on Windows

moodlehq / moodle-docker

A docker environment for moodle developers

GNU General Public License v3.0

376 stars 245 forks source link

Deprecated MOODLE_APP_VERSION variable not properly handled on Windows #166

Closed NeillM closed 3 years ago

NeillM commented 3 years ago

If you use the MOODLE_APP_VERSION on windows the MOODLE_DOCKER_APP_VERSION variable is set with speech marks around it. i.e. as "latest", rather than latest causing moodle-docker not to start with a message like:

ERROR: no such image: moodlehq/moodleapp:"latest": invalid reference format

NeillM commented 3 years ago

I have submitted a pull request to fix this.

stronk7 commented 3 years ago

Related to this, I've created #168 to see if we can have Windows scripts covered in some way.

stronk7 commented 3 years ago

Closing, now that #167 has been merged, thanks!