search

moodlehq / moodle-docker

A docker environment for moodle developers
GNU General Public License v3.0
376 stars 245 forks source link

Update Firefox #194

Closed aspark21 closed 2 years ago

aspark21 commented 2 years ago

Quick first step for #154 is to update the default Firefox version.

Will submit the rewiring separately

aspark21 commented 2 years ago

Fixes #191

stronk7 commented 2 years ago

My understanding is that we are not going to need this once #195 is ready (and supersedes this), correct?

aspark21 commented 2 years ago

Correct.

This was purely the quick fix which would allow tests on the master branch to pass, as master currently fails e.g. https://github.com/aspark21/moodle-docker/actions/runs/1394569767

Which make it seem new contributions break things when in fact master is failing as is.

But #195 is the more long term improvement & more flexible way of dealing with that. Wasn't sure how long #195 would take to implement so I put this one in as a fallback.

aspark21 commented 2 years ago

Closing as #195 is ready