search

moodlehq / moodle-docker

A docker environment for moodle developers
GNU General Public License v3.0
373 stars 244 forks source link

Update git clone command #208

Closed alfonso-salces closed 1 year ago

alfonso-salces commented 2 years ago

Trying to follow the readme documentation I found an Issue related with git clone request protocol.

Outdated points: https://github.com/moodlehq/moodle-docker#use-containers-for-running-behat-tests-for-the-moodle-app https://github.com/moodlehq/moodle-docker/blob/master/tests/app-setup.sh

Command executed: git clone git://<repo>

Throwed error: Clonando en 'moodle-local_moodlemobileapp'... fatal: error remoto: The unauthenticated git protocol on port 9418 is no longer supported. Please see https://github.blog/2021-09-01-improving-git-protocol-security-github/ for more information.

I will create a Pull Request to fix that, using git clone with https protocol.

alfonso-salces commented 2 years ago

Pull request with mentioned fix: https://github.com/moodlehq/moodle-docker/pull/209

stronk7 commented 1 year ago

Closing this because it was fixed indirectly by #210 . Thanks for the issue and the PR!

scara commented 1 year ago

Hi @stronk7,

Closing this because it was fixed indirectly by #210 .

for the sake of community refs 😉, it was fixed by #211.

HTH, Matteo

stronk7 commented 1 year ago

Ah, fun. I copied the reference from #209, where I also pointed, incorrectly, to #210.

You are right, #211 was the one fixing this, thanks!