search

moodlehq / moodle-docker

A docker environment for moodle developers
GNU General Public License v3.0
373 stars 244 forks source link

Verify oracle availability using "DATABASE IS READY TO USE!" #221

Closed stronk7 closed 1 year ago

stronk7 commented 1 year ago

We have ensured that all the oracle database images output at the end of the init script the "DATABASE IS READY TO USE!" text. That has been done by:

https://github.com/moodlehq/moodle-db-oracle/pull/13

(Because Oracle 11g was missing that string)

So, now that the string is available in all moodle-db-oracle images we can start using it here, in moodle-docker.

Still note this is not the ideal wait/health-check system and we'll have to move to a proper one. See:

https://github.com/moodlehq/moodle-docker/issues/160

But it's better than nothing, and the current one based on the "Database opened." string was not working ok for Oracle 21c (that requires 2 startups).

stronk7 commented 1 year ago

If automated tests for the master branch with Oracle now pass... it means the detection of the new string is working as expected.

Before this PR those jobs were failing 50% of time, assuming that the database was ready too early.

Ciao :-)