moodlehq / moodle-docker

A docker environment for moodle developers
GNU General Public License v3.0
373 stars 244 forks source link

multiple moodle-docker improvements #229

Closed skodak closed 1 year ago

skodak commented 1 year ago

Hi guys,

I have started using moodle-docker on my new M2 mac fox all development, I do not even have PHP installed in macOS. I have already created a few pull requests but the changes I did are starting to look like a fork.

Major changes

It should be still mostly compatible with old tooling (apart from new config.php template location).

Please note this is still a work in progress...

scara commented 1 year ago

Hi Petr, this looks great and promising!

I've appreciated the possibility to pass arguments to your bin/docker_down too e.g. --volumes. Even the possibility to comment out ENV VARs or simply internal notes in the optional moodle-docker.env.

Spare time permitted I'll give it a run and provide more thoughts compared to this first glance.

HTH, Matteo

skodak commented 1 year ago

hmm, I have a few more ideas for bugfixing and improvements, I'll close this for now