search

moodlehq / moodle-docker

A docker environment for moodle developers
GNU General Public License v3.0
373 stars 244 forks source link

simplify basedir variable setting #231

Closed skodak closed 1 year ago

skodak commented 1 year ago

I had trouble understanding the magic behind current basedir logic, so I invented a simpler version. It expects that only the executables from bin/* are symlinked or the whole moodle-docker. Symlinking just the bin directory does not make sense to me, they should just add the bin/ to their search path most likely instead.

I will be be using basedir it future patches, the current one seems to be a bit too long to copy/paste into all those other scripts such as waiting for db and app.

I can confirm it works fine in macOS and linux.

stronk7 commented 1 year ago

Side comment: I'd recommend you to install unix utils (or whatever that package is called by your manager, homebrew, macports...). That brings you compatible/GNU versions, instead of the BSD ones, of near everything (grep...) by just putting their path before the default one.

stronk7 commented 1 year ago

Merged, thanks!

skodak commented 1 year ago

hehe, the whole point of improving moodle-docker is so that I do not have to install homebrew or macports in my new M2 mac

anyway cheers!