Open scara opened 1 year ago
That sounds ok for me, can be useful when testing real databases elsewhere (Azure, AWS...) and also local with special debugging, tracing... +1
Hi @stronk7, here is the proposal:
MOODLE_DOCKER_DB
in sync with the type of the external DB server you'll be able to use it e.g. as the local DB clientMy feeling is that (2) would be an option not good for a development toolbox like this one is.
HTH, Matteo
Exactly one year later (Nov 13th!)...
I think that the 1st option is good enough. It allows, any time, to point to another database elsewhere, without touching the "own" one, and easily go back, or use the database CLI to connect to the external instance or whatever.
So +1 to the 1st approach.
Ciao :-)
Hello, while working on MDL-69581 I found an unbalanced situation when playing, better jamming, with the Toolbox environment through an external DB server. Indeed we can set the DB credentials via ENV VAR:
MOODLE_DOCKER_DBNAME
MOODLE_DOCKER_DBUSER
but not the DB Host, not strictly required in the Toolbox ecosystem unless when crossing an external DB instance could be a valuable option still for testing purposes.
Does it make sense? I'd open a PR if it won't hurt adding a new ENV VAR defaulting to
db
(theservice
name in the compose file) and mostly unused.TIA, Matteo