Closed andrewnicols closed 1 year ago
Hi @andrewnicols, LGTM!
Is there any reason not to kept aligned even moodle-docker-compose.cmd
?
TIA, Matteo
Only because I totally forgot when I wrote this several months ago (and am still amazed that people use Windows for development).
I don't have a Windows machine to be able to test it I'm afraid.
Only tiny suggestion that I'd do here is to add a comment about ensuring that the loading of the local.yml
always remains the last one before calling compose. Just to avoid forgetting about that in the future.
Other than that, I think this is the correct way to go, enabling virtually any customisation without overburdening configuration. And, at the same time, it also makes it really easier to test thing that may end into the main scripts if good enough. So big +1 here.
I'll run some basic test under Unix and Windows soon...
Ah, and would be great if we can add the very same ECHO "Including local options from...
to the Windows one. Sorry just saw it now.
Only tiny suggestion that I'd do here is to add a comment about ensuring that the loading of the local.yml always remains the last one before calling compose. Just to avoid forgetting about that in the future.
Done :)
Ah, and would be great if we can add the very same ECHO "Including local options from... to the Windows one. Sorry just saw it now.
And done - hope I got this right.
Thanks, looks perfect! Will test shortly...
Tested both under Unix and Windows, it worked great, so far!
This change adds support for a local yml file to include any customisations that users may wish to include as standard.
This may, for example include changes to existing containers, or it may include the addition of additional containers such as database admin tooling, or proxy servers.