search

moodlehq / moodle-docker

A docker environment for moodle developers
GNU General Public License v3.0
373 stars 244 forks source link

Add support for new sqlsrv driver that is using odbc18 #253

Closed stronk7 closed 1 year ago

stronk7 commented 1 year ago

For more information, see https://github.com/moodlehq/moodle-php-apache/pull/164

Basically, odbc18 enables encrypted connections by default and our stack is not ready for that. So, what we'll be doing here, apart from other solutions is to mimic this from moodle-ci-runner:

https://github.com/moodlehq/moodle-ci-runner/commit/8dcbdc1ca751f48f09f0e2e594b563be2e29ee48

That will allow us to disable encryption from Moodle (4.2dev only).

And, then, thanks to https://tracker.moodle.org/browse/MDL-77669 , get that in all affected (311_STABLE and up) branches.

Again, apart from any other solution that could came late (like making the PHP images to accept the SQL*Server certs and so on.

Ciao :-)

stronk7 commented 1 year ago

Note that, in https://github.com/moodlehq/moodle-php-apache/issues/168 we are going to revert the odbc / php-sqlsrv bump... but no matter of that, once the problems are fixed they will be applied again, so it's good to fix this now (and be ready for whenever the new library and php driver are back).

Ciao :-)