moodlehq / moodle-docker

A docker environment for moodle developers
GNU General Public License v3.0
373 stars 244 forks source link

Remove obsolete version attribute from compose files. #283

Closed paulholden closed 3 months ago

paulholden commented 3 months ago
$ bin/moodle-docker-compose up -d
WARN[0000] /home/pholden/Moodle/Docker/base.yml: `version` is obsolete 
WARN[0000] /home/pholden/Moodle/Docker/service.mail.yml: `version` is obsolete 
WARN[0000] /home/pholden/Moodle/Docker/db.mysql.yml: `version` is obsolete 
WARN[0000] /home/pholden/Moodle/Docker/db.mysql.port.yml: `version` is obsolete 
WARN[0000] /home/pholden/Moodle/Docker/selenium.debug.yml: `version` is obsolete 
WARN[0000] /home/pholden/Moodle/Docker/webserver.port.yml: `version` is obsolete 
[+] Running 5/6
 ⠴ Network docker_default        Created                                                                                                                                                                                                                                   
 ✔ Container docker-exttests-1   Started                                                                                                                                                                                                                                   
 ✔ Container docker-selenium-1   Started                                                                                                                                                                                                                                   
 ✔ Container docker-mailpit-1    Started                                                                                                                                                                                                                                   
 ✔ Container docker-db-1         Started                                                                                                                                                                                                                                   
 ✔ Container docker-webserver-1  Started

Local versions:

$ docker --version
Docker version 25.0.5, build 5dc9bcc
$ docker compose version
Docker Compose version v2.25.0
stronk7 commented 3 months ago

Ok, I've tried here with current Desktop release:

$ docker --version
Docker version 25.0.3, build 4debf41
stronk7@~/git_moodle/moodle-docker (main >)$ docker compose version 
Docker Compose version v2.24.6-desktop.1

And it works perfectly. Curiously I don't get the warnings here (maybe that's something that has been added recently), neither get them if I run docker compose config -f xxxx.

In any case, I'm near sure that the change should be safe (I think that we have commented about the deprecation of those versions in past issues here). So going to merge this now.

If somebody is using any docker compose alternative that faces problems with this change, I imagine that will share the (negative) experience here.

Ciao :-)