search

moodlehq / moodle-docker

A docker environment for moodle developers
GNU General Public License v3.0
419 stars 257 forks source link

Make MOODLE_DOCKER_DB optional #307

Open fulldecent opened 6 days ago

fulldecent commented 6 days ago

In order to setup moodle-docker, it is necessary that you will pick a database.

Many people do not care which database is running. In fact most people that use Moodle do not care which database is running.

So I ask that MOODLE_DOCKER_DB be removed as a required variable to setup moodle-docker.

This removes one line of boilerplate from everybody using this project.

This issue is part of https://github.com/moodlehq/moodle-docker/issues/304, the initiative to make it easier for anybody to get started with trying or developing on Moodle.

fulldecent commented 6 days ago

And yes, this means that the Moodle project should choose one database that it recommend as the starting point for development.

That is a reasonable thing to ask of the Moodle project to do rather than require every developer to spend brain cycles on this before they are able to use Moodle.

scara commented 6 days ago

Hi @fulldecent,

That is a reasonable thing to ask of the Moodle project to do rather than require every developer to spend brain cycles on this before they are able to use Moodle.

it depends on the nature of what developed: back-end stuff could be strongly db-dependent, especially in testing the changes around queries.

HTH, Matteo

fulldecent commented 6 days ago

That is absolutely correct. And most people are not doing strongly db-dependent backend stuff.

So a reasonable default database could make this project multiple minutes easier to approach for everybody else by making that option have a default value.