search

moodlehq / moodle-local_codechecker

A Moodle local plugin providing a simple web UI to run the MoodleCS coding style checks with PHP_CodeSniffer.
63 stars 72 forks source link

[CONTRIB-8264] Warn about deprecated @expectedExceptionXXX phpunit annotations #129

Closed sarjona closed 3 years ago

sarjona commented 3 years ago

Starting with PHPUnit 8.5, the @expectedExceptionXXX annotations are deprecated and, instead of the ->expectExceptionXXX() methods should be used, exactly before the line that is going to throw the exception.

This issue is about to enable moodlecheck (or, if easier, codechecker) to be aware of this deprecation, starting to warn about it. Ideally, only for 310 and up, if that's possible.

Reporter: Eloy Lafuente Original issue: https://tracker.moodle.org/browse/CONTRIB-8264

stronk7 commented 3 years ago

This was finally implemented @ https://github.com/moodlehq/moodle-local_moodlecheck/pull/76 , so closing this.