search

moodlehq / moodle-local_codechecker

A Moodle local plugin providing a simple web UI to run the MoodleCS coding style checks with PHP_CodeSniffer.
63 stars 72 forks source link

Various own ci fixes #144

Closed stronk7 closed 3 years ago

stronk7 commented 3 years ago

The changes are all internal towards own CI passing.

They are 3 commits, each one self-explanatory. Not much else to say. Just ensure that GHA and travis are happy with the code and done.

Ciao :-)

stronk7 commented 3 years ago

Uhm... the failures in travis above (GHA is passing), are really strange... never had seen them before. We aren't for sure opening so many descriptors / files in those tests, just a few.

$ moodle-plugin-ci phpunit --coverage-text
 RUN  PHPUnit tests for local_codechecker
Moodle 3.5.17+ (Build: 20210324), 79d4f46efdb0bcd9059dd725e79c4f1eeb05375c
Php: 7.2.15, pgsql: 9.6.18, OS: Linux 4.15.0-1077-gcp x86_64
PHPUnit 6.5.14 by Sebastian Bergmann and contributors.
50
EEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEE                            38 / 38 (100%)

Time: 8.56 seconds, Memory: 56.00MB

There were 38 errors:

1) moodlestandard_testcase::test_psr2_methods_methoddeclaration
stream_select(): You MUST recompile PHP with a larger value of FD_SETSIZE.
It is set to 1024, but you have descriptors numbered at least as high as 1055.
 --enable-fd-setsize=2048 is recommended, but you may want to set it
to equal the maximum number of open files supported by your system,
in order to avoid seeing this error again at a later date.

/home/travis/build/moodle/local/codechecker/phpcs/src/Config.php:388
/home/travis/build/moodle/local/codechecker/tests/local_codechecker_testcase.php:247
/home/travis/build/moodle/local/codechecker/moodle/tests/moodlestandard_test.php:70
...
...

Just guessing if, maybe, it's because of xdebug enabled (now that we use the coverage options) or something like that. Will try without the coverage option to see if it makes any difference... strange!

stronk7 commented 3 years ago

Have added an extra commit to travis, disabling --coverage-text for PHPUnit... let's see if that makes any difference.

stronk7 commented 3 years ago

Aha, confirmed, with the 4th commit disabling coverage... all them are passing, so this is ready :-)