search

moodlehq / moodle-local_codechecker

A Moodle local plugin providing a simple web UI to run the MoodleCS coding style checks with PHP_CodeSniffer.
63 stars 72 forks source link

Start informing (warning) about not needed MOODLE_INTERNAL uses #152

Closed stronk7 closed 2 years ago

stronk7 commented 3 years ago

In https://tracker.moodle.org/browse/MDLSITE-5967 it was decided that it's ok to omit the MOODLE_INTERNAL check for 1-artifact files without side effects.

And we did that in the codechecker (and coding style details).

Now it's time to introduce a new warning about that, aka detected not needed uses. When a file is 1-artifact and without side effects, better don't add the MOODLE_INTERNAL check.

The other side of the agreement, basically. So we stop getting too many, now unnecessary, checks in the new files.

Ciao :-)