moodlehq / moodle-local_codechecker

A Moodle local plugin providing a simple web UI to run the MoodleCS coding style checks with PHP_CodeSniffer.
63 stars 72 forks source link

Downgrade code to be PHP 7.0 compliant. #162

Closed stronk7 closed 2 years ago

stronk7 commented 2 years ago

We need codechecker to continue working with PHP 7.0, because it's used by moodle-plugin-ci that supports that version.

Hence, we have to downgrade code till it's decided to raise requirements in both products.

Not much problem, only a few code recently introduced (using some optional return type hinting that was added with PHP 7.1) needs to be downgraded.

stronk7 commented 2 years ago

Have created #162 to revert this once we raise requirements to PHP 7.2 and up.

stronk7 commented 2 years ago

Self-merging to make a new release ASAP.