Avoid comma-separated use statements to require MOODLE_INTERNAL

moodlehq / moodle-local_codechecker

A Moodle local plugin providing a simple web UI to run the MoodleCS coding style checks with PHP_CodeSniffer.

63 stars 72 forks source link

Avoid comma-separated use statements to require MOODLE_INTERNAL #176

Closed stronk7 closed 2 years ago

stronk7 commented 2 years ago

No matter that comma-separated use statements are a violation of the coding style (see Namespaces section), they, for sure, don't constitute a side-effect at all, so the MOODLE_INTERNAL check should be immune to them.

This fix just enables comma-separated to be properly processed, covered with tests.

Fixes #175

stronk7 commented 2 years ago

Self-merging to have this deployed @ CI ASAP.