search

moodlehq / moodle-local_codechecker

A Moodle local plugin providing a simple web UI to run the MoodleCS coding style checks with PHP_CodeSniffer.
63 stars 72 forks source link

Compatibility with PHP 8.1 #201

Closed marinaglancy closed 11 months ago

stronk7 commented 1 year ago

Hi @marinaglancy , would you mind rebasing this (now that we have completed the transition to moodle-cs and everything is now in place). Just to verify if we get a pass with the GHA jobs.

Ciao :-)

stronk7 commented 1 year ago

Hi @marinaglancy , I've proceeded to rebase your branch on top of current master, let's see how it ends (GHA-wise).

Ciao :-)

stronk7 commented 1 year ago

BTW, I've just checked and those changes (or similar) aren't upstream, so maybe we should report them or reproduce how they are happening to see if they are fixed elsewhere (in some caller, higher level or so...).

It's strange they have not fixed them but we need to do so... uhm...

Ciao :-)

stronk7 commented 11 months ago

Closing this as won't fix because in #221 we are moving to Composer based installation of dependencies. So this cannot be fixed locally anymore.