search

moodlehq / moodle-local_codechecker

A Moodle local plugin providing a simple web UI to run the MoodleCS coding style checks with PHP_CodeSniffer.
63 stars 72 forks source link

Allow CRLF files in /tests/fixtures/ directories #205

Closed stronk7 closed 2 years ago

stronk7 commented 2 years ago

In #203 it was proposed to allow CRLF files in Moodle, because the original CSV specs say that those files should be CRLF.

But in practice, nowadays hardly any file is CRLF and, specifically for Moodle, we have banned them in core since the night of the times.

And we should continue not allowing them. Hence we are only allowing those CRLF CSV files within the /tests/fixtures/ directories, that way if anybody wants to test their CSV loaders with CRLF, they can have some fixtures at hand.

Everywhere else, they will continue being forbidden.

Fixes #203

stronk7 commented 2 years ago

Have added one extra commit, unrelated to the issue being fixed here, but that updates the GHA environment to current supported Ubuntu 22.04. It shouldn't affect the outcome, let's see.