search

moodlehq / moodle-local_codechecker

A Moodle local plugin providing a simple web UI to run the MoodleCS coding style checks with PHP_CodeSniffer.
63 stars 72 forks source link

Checks give incorrect notification in flat arrays #217

Closed NeillM closed 1 year ago

NeillM commented 1 year ago

This result seems incorrect to me, it does not appear to recognising the array correctly.

#78: ········$banner·=$generator->create_banner(['position'·=>·1]); Expected 1 space after "="; 0 found

This is happening in the latest version of the master branch

andrewnicols commented 1 year ago

WhTs wrong with that? It’s missing an = before $generator

On Wed, 12 Jul 2023 at 19:01, Neill Magill @.***> wrote:

This result seems incorrect to me, it does not appear to recognising the array correctly.

78: ········$banner·=$generator->create_banner(['position'·=>·1]);

Expected 1 space after "="; 0 found

— Reply to this email directly, view it on GitHub https://github.com/moodlehq/moodle-local_codechecker/issues/217, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAC2K77DLDQY54GTJZXCKZ3XPZ7XZANCNFSM6AAAAAA2HJ5XIQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

NeillM commented 1 year ago

Doh! I misread it, apologies.