search

moodlehq / moodle-local_codechecker

A Moodle local plugin providing a simple web UI to run the MoodleCS coding style checks with PHP_CodeSniffer.
63 stars 72 forks source link

Feature Request: Legacy file is not showing any errors #238

Open purnendudash opened 5 months ago

purnendudash commented 5 months ago

If we do check any plugin via code checker and have file like this

https://moodledev.io/docs/4.4/apis/commonfiles#libphp

even

file like - https://moodledev.io/docs/4.4/apis/commonfiles#locallibphp

It does not showing any warning / error. There should be some checking about the legacy thing.

Kindly let me know if this feature is already there via some config etc.

stronk7 commented 5 months ago

Hi @purnendudash ,

I'm not sure if I'm following, I'm not aware of any restriction to check those lib.php or locallib.php files.

Just to test it, I've run the codechecker from the web, setting mod/label as the path to examine, and it's finding the problems in mod/label/lib.php perfectly.

mod_label_lib

So, not sure which your problem can be, those files are, so far, checked.

Ciao :-)

Jayanta7022 commented 5 months ago

Screenshot 2024-05-17 171824

In new structure in some places the locallib.php has become a Legacy file. It would be a huge help if your code checker suggests us that it is a legacy file .