moodlehq / moodle-local_codechecker

A Moodle local plugin providing a simple web UI to run the MoodleCS coding style checks with PHP_CodeSniffer.
63 stars 72 forks source link

Validation error for using `global $PAGE` in block classes #240

Open eduardokraus opened 1 month ago

eduardokraus commented 1 month ago

I created a class called block_type, and when running the code checker, I received the following error message:

global $PAGE cannot be used in block classes. Use $this->page.

Captura de Tela 2024-09-10 às 20 22 13

Steps to reproduce:

  1. Create a block class (e.g., block_type).
  2. Try using global $PAGE within the class.
  3. Run the code checker.

Expected behavior:

The code checker should allow the use of global $PAGE in appropriate contexts or provide a clearer message on how to adjust the code.

Current behavior:

The checker throws an error suggesting the use of $this->page without adequately explaining the situations where this should be applied.

Environment:

Possible solution:

It would be helpful to review the checker's logic to recognize the context where global $PAGE might be necessary or to better document when $this->page should be used.

Thank you!