search

moodlehq / moodle-local_codechecker

A Moodle local plugin providing a simple web UI to run the MoodleCS coding style checks with PHP_CodeSniffer.
63 stars 72 forks source link

Enable code checker checks in .travis.yml when moodle-plugins-ci runs local_codechecker 3 #97

Closed stronk7 closed 2 years ago

stronk7 commented 3 years ago

In dfff50bcd94d184607aef7b654d3261ed7256a46 we disabled in our {{.travis.yml}} file the execution of the codechecker (because codechecker 2 cannot check codechecker 3). This is because moodle-plugin-ci continues pointing to codechecker 2.9.8.

https://github.com/moodlehq/moodle-plugin-ci/issues/49 has been created to update moodle-plugin-ci to codechecker 3 final release. Once that's done and there is a compatible version... we'll revert the commit above and codechecker codebase itself will be checked by codechecker.

Ciao :-)

stronk7 commented 2 years ago

This was fixed as part of #131, while adding support for GHA to this repo. And later removed, when dropping support for Travis from this repo at #159 .

So, we can close this now. Proceeding.