search

moodlehq / moodle-mlbackend-python

Moodle machine learning backend
GNU General Public License v3.0
18 stars 19 forks source link

Mdl 67040 master #19

Closed dmonllao closed 4 years ago

dmonllao commented 4 years ago

This pull request includes MDL-67622, which should be integrated before this issue.

stronk7 commented 4 years ago

Must confess that this is mostly encrypted code for me, but as far as unit tests continue passing ok, I think it's ok to accept it. I'd have expected some unit test covering the new cases / login implemented but...

stronk7 commented 4 years ago

For the records, both 38_STABLE and master are passing with this patch to the python mlbackend applied:

$ python -m moodlemlbackend.version
2.4.0

$ vendor/bin/phpunit analytics/tests/prediction_test.php -v
Moodle 3.8.1 (Build: 20200113), 8f112b1064557a1c1a39ade249513e652694bc3e
Php: 7.3.13, pgsql: 9.6.16, OS: Darwin 19.2.0 x86_64
PHPUnit 7.5.17 by Sebastian Bergmann and contributors.

Runtime:       PHP 7.3.13
Configuration: /Users/stronk7/git_moodle/integration/phpunit.xml

..........................                                        26 / 26 (100%)

Time: 3.21 minutes, Memory: 66.50 MB

OK (26 tests, 270 assertions)

$ vendor/bin/phpunit analytics/tests/prediction_test.php -v
Moodle 3.9dev (Build: 20200109), 2307ee083a0361ebe22051d483861f693db790f4
Php: 7.3.13, pgsql: 9.6.16, OS: Darwin 19.2.0 x86_64
PHPUnit 7.5.18 by Sebastian Bergmann and contributors.

Runtime:       PHP 7.3.13
Configuration: /Users/stronk7/git_moodle/integration/phpunit.xml

..........................                                        26 / 26 (100%)

Time: 3.1 minutes, Memory: 66.50 MB

OK (26 tests, 270 assertions)
stronk7 commented 4 years ago

Merged!

Next steps: