search

moodlehq / moodle-mlbackend-python

Moodle machine learning backend
GNU General Public License v3.0
18 stars 19 forks source link

Misc small improvements #21

Closed douglasbagnall closed 4 years ago

douglasbagnall commented 4 years ago

The last patch, changing the default listen mode when run from the command line might be the trickiest to merge, since it is bound to break somebody's set-up -- but I think the more secure default is better.

stronk7 commented 4 years ago

Yeah, all the changes here make sense and seem good improvements.

But the last one that may affect some sites (depending of their very own infrastructure).

So, or we bump version to, say, 2.5.0 and warn everywhere about the change. Or we bump to 3.0.0 and make it master only (if we decide the 3.x raise... maybe we could split that 4th commit and delay it until everything else is merged. Just to delay branching as much as possible).

Any preference about the 2.5.0+warn vs 3.0.0 ?

douglasbagnall commented 4 years ago

superseded by #27, which incorporates these commits (c.f. #26).