search

moodlehq / moodle-mlbackend-python

Moodle machine learning backend
GNU General Public License v3.0
18 stars 19 forks source link

Add some tests and an INSTALL document #24

Closed douglasbagnall closed 4 years ago

douglasbagnall commented 4 years ago

Tests are good. Unfortunately these ones are incomplete and possibly wrong in places.

There are a few that are marked as xfail, and they fail as expected. In some cases (e.g /evaluation) I have not understood the expected result, others are WIP. Others only succeed because they don't really assert anything significant. We don't, for example, show that training successfully trains.

I think it would be good to have the tests merged now in any case, as they are certainly better than nothing, and it makes it easier to develop new features with existing tests in place.

douglasbagnall commented 4 years ago

the new commits show that training and prediction work (using a toy dataset), and all but one of the xfails are gone.

There is also a patch in there to allow the webapp and tests to run without having boto3 installed.

douglasbagnall commented 4 years ago

see #30.