stronk7
commented
10 years ago uhm, strange. I've executed compare.sh again and now (with some debugging) before_branch.sh has been perfectly able to set the new values into test_files.properties, replacing the old (october 22) ones. I don't understand why they were not written in my first attempt. Same user all the time, didn't get any error in my first execution of before_branch… aparently!
we need to make all those scripts to exit on error everywhere. Else it's impossible to get the exact moment when a problem in step A (before_branch.sh), leads to worse error in step B (after_branch.sh). I'm 99% sure that something went wrong in my first execution of A, because that's the script writing the info to the properties file.
Feel free to close this or convert it to: "scripts should exit on error unconditionally"
Ciao :-)
dmonllao
I had a site with some old runs on it, so 2 days ago (october 22), I proceed to:
1) clean_data.sh 2) run a new ./compare.sh, comparing 25_STABLE with master.
Today (october 24), I've applied your latest patches and also the "thresholds" pull request and have proceed to:
1) clean_data.sh 2) run a new ./compare.sh, comparing 25_STABLE with master.
Then:
Got an error (after_branch):
Users/stronk7/Sites/perf_backups/dataroot_backup_201310221712: No such file or directory ./after_run_setup.sh: line 79: /Users/stronk7/Sites/perf_backups/database_backup_201310221712.sql
So, at some point, the OLD, already deleted (october 22) backup is still there in test_files.properties and it never has been updated to point to the new (october 24) backups.
Ciao :-)