search

moodlehq / moodle-performance-comparison

Set of shell scripts to run Moodle performance tests using different hardware and configurations and compare results.
GNU General Public License v2.0
75 stars 39 forks source link

Look for exceptions in jmeter logs #39

Closed dmonllao closed 10 years ago

dmonllao commented 10 years ago

Jmeter does not always return an error code when there was an error. We should grep the generated logs files to look for them ("Exception", "Error"...) to stpo execution if something went wrong.

dmonllao commented 10 years ago

Anyone keen to review it? (oh I hear people punching each other to review it, there is a lot of demand, be quick or they will review it before you)

danpoltawski commented 10 years ago

Seems fine to me. Only question is whether its always a problem with those tokens found.

dmonllao commented 10 years ago

Thanks for the review. Yes, I have the same doubt too, but I haven't found any trace of a similar error, only "error" in lowercase... What do you think of acting passively and add a "If you find that this a false failure report the issue in https://github.com/moodlehq/moodle-performance-comparison/issues" to the error string? I don't know if we have more margin here.

dmonllao commented 10 years ago

I think a8aeef63e0b501d29a7339927fa3c217bd82f047 is the champion. Waiting for complains for a couple of hours, otherwise merging in 25, 26 and master.

danpoltawski commented 10 years ago

Have commented on the patch - I think you can simplify it.

dmonllao commented 10 years ago

Thanks for the info Dan, I didn't know that is that easy to avoid problems with set -e.

New alpha male candidate: bf8ea67eb82db9f0ac14683186b38f6e7ac55354

dmonllao commented 10 years ago

Thanks Dan, changes merged in 25, 26 and master