search

moodlehq / moodle-performance-comparison

Set of shell scripts to run Moodle performance tests using different hardware and configurations and compare results.
GNU General Public License v2.0
76 stars 40 forks source link

Add a new var: "Time elapsed by the DB engine running DB queries" #43

Closed dmonllao closed 10 years ago

dmonllao commented 10 years ago

Following https://tracker.moodle.org/browse/MDL-43758, we should catch this new var and compare it's values like we do with all other vars.

MDL-43758 will probably be only integrated in master (Moodle 2.7dev) so I'm not 100% sure now whether we just need to add the var or we will have to treat vars conditionally depending on their availability in the HTML source code.

dmonllao commented 10 years ago

Keeping it blocked by https://github.com/moodlehq/moodle-performance-comparison/issues/10 to avoid possible conflicts (and, as a collateral damage, to get #10 reviewed earlier :P)

dmonllao commented 10 years ago

I can imagine misleading results with this integrated and DB engine caches... probably would be good to add some info in the README about it.

dmonllao commented 10 years ago

https://tracker.moodle.org/browse/MDL-43882 waiting for peer review before beginning with this

stronk7 commented 10 years ago

+1

dmonllao commented 10 years ago

All good to me, I would just rename the new get_run_vars() to get_run_vars_names() if it is only returning a list of strings and comment somewhere in the README about how unstable the results of this var can be depending on your database engine configuration, also this makes me think that the default threshold values should be increased.

dmonllao commented 10 years ago

I have been running a few compare.sh using a pgsql installation with the default values and the value results are pretty unstable in my case.

rajeshtaneja commented 10 years ago

Thanks David and Eloy,

I have renamed function to get_run_var_names() and added information about varying value for db query time. This is now part of moodle-performance-comparison tool.