search

moodlehq / moodle-performance-comparison

Set of shell scripts to run Moodle performance tests using different hardware and configurations and compare results.
GNU General Public License v2.0
75 stars 39 forks source link

delete_files() and wildcards #46

Closed schach closed 9 years ago

schach commented 10 years ago

First of all thank you for this great set of tools. This makes Moodle performance testing a breeze.

I noticed that deletefiles() won't work for strings like "runs/.php" in cleandata.sh. It seems like the whole string is interpreted as a literal: rm "runs/.php". With quotes removed in lib.php, last line of delete_files(), it works as expected: rm -rf $1

rajeshtaneja commented 9 years ago

Thanks for spotting this schach,

Patch resolving this issue: https://github.com/rajeshtaneja/moodle-performance-comparison/commit/f11856c6519a418299f063ba58e9bc0a2d4106c3

Requesting Eloy/David to review it.

dmonllao commented 9 years ago

Thanks @schach for spotting it and @rajeshtaneja for fixing, it looks good.

rajeshtaneja commented 9 years ago

Thanks guys, This is part of performance comparison tool.