moodlehq / moodle-performance-comparison

Set of shell scripts to run Moodle performance tests using different hardware and configurations and compare results.
GNU General Public License v2.0
75 stars 39 forks source link

Fix non well-formed numeric value with PHP7 issues #59

Closed dmonllao closed 7 years ago

dmonllao commented 7 years ago

Different fixes:

IMPORTANT NOTE FOR THE INTEGRATOR: webapp/classes/test_plan_runs.php changes should be enough as long as we don't compare results recorded before this fix and after, in normal circumstances we only test latest weekly against current integration, so Friday after the release seems the best time to integrate this. We could only avoid the compare previous results thing by updating all previously generated files which would require time. Any opinion?

danpoltawski commented 7 years ago

Thanks David, as discussed in Integration chat, the patch makes the assumption that session size doesn't grow above 1MB. This seems a reasonable tradeoff.

dmonllao commented 7 years ago

Thanks Dan, as discussed in integration team chat rounded session sizes rounded to 0 are returned without a comma, so this solution is not good enough. I will send a further improvement.