search

moodlehq / moodle-php-apache

PHP + Apache docker images for Moodle development
61 stars 68 forks source link

Revert #164 while the related problems are fixed. #168

Closed stronk7 closed 1 year ago

stronk7 commented 1 year ago

In #164 we updated to:

And it has caused a couple of problems:

  1. With ODBC 18, connections are encrypted by default, so we need a way to disable that encryption or to relax the certificate verifications. That's already fixed for 4.2dev (master) and will be also solved by MDL-77669 in stables. Both moodle-ci-runner and moodle-docker will use those new configuration abilities to solve the problem.
  2. Apart from the above, there are some consistent failures (PHPUnit till now) detected with the new libraries / php extension. See for example these runs: link1, link2. MDL-77678 has been created to fix that.

Most of the problems in #2 seem to happen within tests using ADOdb (and not our own drivers), so may be it's a matter of passing the new connection parameters to ADODb.

In any case, because of the 2 problems above and until they are fixed, this issue is about to revert #164 so we are back to the previous versions and back to green.

Ciao :-)

Edited: to add link to MDL-77678..

stronk7 commented 1 year ago

For the records, I'm reverting the changes in the following moodle-php-apache images:

And I'm leaving with the ODBC 18 library and the new php-sqlsrv drivers the following images:

So we can test things with buster images while the bullseye ones (default @ CI) continue using the old / safe library and driver.

Ciao :-)

stronk7 commented 1 year ago

Closing this as done, the images commented above (bullseye and master) are now being re-built and will be soon available @ dockerhub.

Ciao :-)