moodlehq / moodle-plugin-ci

Helps running Moodle plugins analysis checks and tests under various CI environments.
https://moodlehq.github.io/moodle-plugin-ci/
GNU General Public License v3.0
41 stars 43 forks source link

Configure browser capabilities #269

Closed NoelDeMartin closed 5 months ago

NoelDeMartin commented 5 months ago

I have tried using the add-config command to achieve this instead, but it seems like the Behat configuration is created in the install command so changes done afterwards are not applied. And if I try to use the add-config command before installing, I get an error.

So the only solution I've found is to modify config.php.txt before running the install command, but that's a bit fickle so it would be nice to have an idiomatic way to achieve it.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (90bc221) 87.89% compared to head (b8e0c2e) 87.92%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #269 +/- ## ============================================ + Coverage 87.89% 87.92% +0.03% - Complexity 725 728 +3 ============================================ Files 75 75 Lines 2222 2228 +6 ============================================ + Hits 1953 1959 +6 Misses 269 269 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

stronk7 commented 5 months ago

Maybe we could add some test applying for capabilities and check the results in config file? If it's complex to do, please create an issue to do it apart from this. You decide, 100% (I've not looked how achievable it is).

Ciao :-)

NoelDeMartin commented 5 months ago

Thanks @stronk7, I've added a couple of tests duplicating the config file fixture, I think that's the easiest way.