search

moodlehq / moodle-plugin-ci

Helps running Moodle plugins analysis checks and tests under various CI environments.
https://moodlehq.github.io/moodle-plugin-ci/
GNU General Public License v3.0
41 stars 43 forks source link

Validation of dataformat - custom plugin name lang string #273

Closed marinaglancy closed 3 months ago

marinaglancy commented 4 months ago

moodle-plugin-ci validate fails on dataformat plugins because they use language string 'dataformat' as a plugin name.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (158d5fd) 87.92% compared to head (8cd51d0) 87.94%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #273 +/- ## ============================================ + Coverage 87.92% 87.94% +0.01% - Complexity 728 729 +1 ============================================ Files 75 76 +1 Lines 2228 2231 +3 ============================================ + Hits 1959 1962 +3 Misses 269 269 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

marinaglancy commented 4 months ago

I don't know if I should change anything in the file headers - they mention "Copyright (C) Blackboard"

kabalin commented 4 months ago

I don't know if I should change anything in the file headers - they mention "Copyright (C) Blackboard"

I think put yourself there, Eloy does.

marinaglancy commented 4 months ago

I changed the copyrights

stronk7 commented 4 months ago

pong!