search

moodlehq / moodle-plugin-ci

Helps running Moodle plugins analysis checks and tests under various CI environments.
https://moodlehq.github.io/moodle-plugin-ci/
GNU General Public License v3.0
46 stars 45 forks source link

Update App config defaults #274

Closed NoelDeMartin closed 3 months ago

NoelDeMartin commented 7 months ago

I'm opening this PR as a draft because until v4.4.0 of the app is released, these defaults don't work with the moodlehq/moodleapp:latest-test image, which is the default (they only work with moodlehq/moodleapp:next-test). But we can get the review started so that once 4.4.0 is released, we can merge this.

moodle-docker has a similar issue, but given that we explicitly support different versions, I've implemented an interim solution in https://github.com/moodlehq/moodle-docker/pull/281.

But for moodle-plugin-ci, I think it's fine just to support one version out of the box. And anyone can configure old versions if they want using other env variables (the documentation has also been updated).

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.25%. Comparing base (30f6347) to head (0f5aebe).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #274 +/- ## ============================================ + Coverage 88.23% 88.25% +0.02% - Complexity 735 739 +4 ============================================ Files 76 76 Lines 2270 2274 +4 ============================================ + Hits 2003 2007 +4 Misses 267 267 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.