search

moodlehq / moodle-plugin-ci

Helps running Moodle plugins analysis checks and tests under various CI environments.
https://moodlehq.github.io/moodle-plugin-ci/
GNU General Public License v3.0
41 stars 43 forks source link

Add ignore-npm-dependencies setting #277

Closed PhMemmel closed 4 months ago

PhMemmel commented 4 months ago

Closes #276

stronk7 commented 4 months ago

Thanks @PhMemmel ,

going to amend your commit from here to make CIs happy and then will merge this.

Normally I'd ask you for the changes, but as far as we are going to make a release later today, better I get on this now. Will add one extra commit to your branch.

Ciao :-)

PhMemmel commented 4 months ago

Appreciate this very much, feel free to make any changes. Thank you!

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.04%. Comparing base (158d5fd) to head (c2ce78d).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #277 +/- ## ============================================ + Coverage 87.92% 88.04% +0.12% - Complexity 728 731 +3 ============================================ Files 75 75 Lines 2228 2234 +6 ============================================ + Hits 1959 1967 +8 + Misses 269 267 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

stronk7 commented 4 months ago

Ok, I've added one extra commit on top of your branch.

Basically it renames the new option to no-plugin-node (to better differentiate moodle node dependencies and plugin node dependencies), fixes tests and covers the new logic a little bit better.

Let's see if GHA is happy...