search

moodlehq / moodle-plugin-ci

Helps running Moodle plugins analysis checks and tests under various CI environments.
https://moodlehq.github.io/moodle-plugin-ci/
GNU General Public License v3.0
46 stars 45 forks source link

Limit stylelint tasks to plugin directory #278

Closed PhMemmel closed 3 months ago

PhMemmel commented 7 months ago

Closes #256

stronk7 commented 6 months ago

Hi @PhMemmel ,

I've put this a little bit on hold until we discuss @ #256 . Thanks for your patience!

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.23%. Comparing base (cdb52da) to head (6b5a114).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #278 +/- ## ========================================= Coverage 88.23% 88.23% Complexity 735 735 ========================================= Files 76 76 Lines 2269 2270 +1 ========================================= + Hits 2002 2003 +1 Misses 267 267 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

stronk7 commented 3 months ago

Hi @PhMemmel ,

I've taken the liberty of amending your commit, fixing some styling details, one test that was failing and adding the information to the changelog file.

Hope that's ok for you. If you're happy, I'll be merging this once we get all checks passing.

Ciao :-)

PhMemmel commented 3 months ago

Feel free to add whatever is necessary! Thank you very much for taking over!

stronk7 commented 3 months ago

Merged, let's see if we can roll this soon... thanks @PhMemmel !