search

moodlehq / moodle-plugin-ci

Helps running Moodle plugins analysis checks and tests under various CI environments.
https://moodlehq.github.io/moodle-plugin-ci/
GNU General Public License v3.0
46 stars 45 forks source link

Be stricter and don't allow warnings on phpcs tests #296

Closed stronk7 closed 6 months ago

stronk7 commented 6 months ago

Just ensure that we fail on self integration tests (phpcs) warnings, so we can monitor the impact of every new moodle-cs release better.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.20%. Comparing base (1554c71) to head (45a012f).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #296 +/- ## ========================================= Coverage 88.20% 88.20% Complexity 731 731 ========================================= Files 75 75 Lines 2264 2264 ========================================= Hits 1997 1997 Misses 267 267 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

stronk7 commented 6 months ago

I'm going to self-merge this. It's just self tests becoming stricter so we can add some more cases to our "fixture" local_ci plugin and check better how moodle-cs changes behave and impact.