search

moodlehq / moodle-plugin-ci

Helps running Moodle plugins analysis checks and tests under various CI environments.
https://moodlehq.github.io/moodle-plugin-ci/
GNU General Public License v3.0
41 stars 43 forks source link

Issue #297 #301

Open ewallah opened 2 months ago

ewallah commented 2 months ago

Grunt job is not ignoring hidden directories #297

stronk7 commented 1 month ago

Hi @ewallah ,

it seems that there are a few coding-style little changes to apply, plus unit tests are failing with your patch.

Is it ok if I amend your branch to make it CI compliant? Other than that, I think that the approach is correct and we can skip dot files without problem (at very least for grunt purposes).

stronk7 commented 1 month ago

Oh, @ewallah,

I just was adding here a test and confirmed that FilesystemIterator::SKIP_DOTS does not skip all dot (hidden) files (.something.txt, .git, ...) but, exclusively, the "." and ".." directories. Hidden files and folders continue being returned by the iterator.

So, this doesn't seem to be enough to achieve what was desired (skip hidden dirs).

ewallah commented 1 month ago

Weird, since I added the SKIP_DOTS, I do not see any permission errors any more.

Feel free to add/change whatever is necessary!