search

moodlehq / moodle-plugin-release

Template for GitHub Actions YAML file allowing to automatically release tagged version in the Moodle Plugins directory
GNU General Public License v3.0
15 stars 4 forks source link

GitHub release not marked as "already released as..." #6

Closed ndunand closed 3 years ago

ndunand commented 3 years ago

Hello,

After releasing a couple plugin versions through this GitHub workflow, I noticed a small incoherence in the Moodle plugins directory:

The versions previously released manually from Github through the Moodle Plugins Database using Developer Zone > Add a new version > GitHub... are marked as "already released as..." to indicate a link between a moodle.org release and a GitHub release tag. However, the release 20210621(as shown below) is not marked as "already released as..." but it should be. The only difference is that is was released using this workflow.

Screen Shot 2021-06-22 at 08 06 34

See https://moodle.org/plugins/atto_morefontcolors/versions for details.

mudrd8mz commented 3 years ago

Ah yes - good catch! The reason here is that the tag name is not submitted to the WS and so is not associated with the version in the plugins directory.

You can fix the already uploaded versions by editing them and filling the tag manually for now: Versions > Edit details > Version control information > VCS tag

ndunand commented 3 years ago

Thanks for the explanation. This is not really an issue for me but I noticed it as I was showing someone the details of this workflow.

mudrd8mz commented 3 years ago

Thanks @ndunand I still plan to fix this eventually, if possible.

mudrd8mz commented 3 years ago

The new version of the moodle-plugin-release.yml fixes this by correctly providing all the VCS related meta-data.