Open danpoltawski opened 7 years ago
Hi Dan, can you pull and try https://github.com/dmonllao/who-broke-it/tree/fix-behat-runner? works as expected to me, but we still need to check osx
It works, but.. the last two lines..
** Running vendor/bin/behat --config /Users/danp/moodles/im/moodledata_behat/behatrun/behat/behat.yml --stop-on-failure mod/quiz/tests/behat/editing_section_headings.feature **
** Failed feature name could not be determined **
** $failedtest not modified **
mmmm, yes, we will need to explain this better.
The first message is the running command, behat failed again but the failing feature file path (probably the same than before) can not be determined. I haven't modified Rajesh original's formula to extract the feature (https://github.com/dmonllao/who-broke-it/blob/fix-behat-runner/run-moodle-behat.sh#L84) I guess a combination of a stronger regex to extract the feature file and rewording the error would be enough.
Just updated the pull branch, it should be fine now: https://github.com/dmonllao/who-broke-it/compare/master...fix-behat-runner
I'm not sure if this is a mac bash incompability..
But I ran who broke it and it failed silently:
I worked out it was existing at the behatoutput line (whcih made sense to me, because it exited on failure), so i applied this patch:
But I don't quite understand why that works on other systems (and it seemed like the bisect didn't work also)