moodlehu / moodle-mod_etherpadlite

This is a moodle plugin for etherpadlite, developed at the Humboldt Universität zu Berlin
20 stars 26 forks source link

Add optional feature: copy button for the pad link in the menu. #47

Closed Menrath closed 2 years ago

Menrath commented 2 years ago

As discussed in #46.

grabs commented 2 years ago

Hi André,

thank you for the feature patch! But I still don't see the benefit of this feature. Can you explain in few words, in what situation the pad-url is usefull? As I wrote earlier, the pad url is usually not usable outside the of Moodle. So who benefits from this? Could you modify your patch a little? I would like to avoid using deprecated javascript. So, maybe you could use the "core/str" module to load the strings in your javascript instead of "M.util.get_string()"? Example:

    require(['core/notification', 'core/str'], function(notification, str) {
        str.get_strings([
            {key: 'link_copied', component: 'mod_etherpadlite'},
            {key: 'etherpadlite_link_copied_to_clipboard', component: 'mod_etherpadlite'}
        ]).then(function(strings) {
            notification.alert(
                strings[0],
                strings[1]
            );
        });
    });

With this you could avoid the usage of the old style "requires->strings_for_js()" and you only have to maintain the strings on a single place.

Best regards Andreas

Menrath commented 2 years ago

Dear Andreas,

thanks for pointing me out on that one. Sometimes when I look something up on the Moodle wiki, I miss the hint that this documentation site is deprecated, this notice is often not well placed visibly.

The idea of exporting the etherpad link didn't came out directly, more as a workaround. In the future we aim for a really good integration of element/matrix within moodle. Element/matrix also allows to add widgets inside chatrooms. As our matrix/element services live on the same second level domain, for now this allows it to manually add certain pads as a widget to a chatroom. As long as the same browser is used and the moodle login is active, which is most likely the case, you have access to the pad.

Greetings, André

grabs commented 2 years ago

Hi André, sorry for taking so long. I removed the db/de folder and squashed your commits to a single one and integrated it manually into the MOODLE_311_STABLE branch. I did not use this pull request directly. I hop this is ok for you. Thanks for your work on this! Andreas

Menrath commented 2 years ago

Hey Andreas, no problem! Thank again for you help, guidance and efforts! I was happy to contribute. Greetings, André