readonly url and groupmode fix

moodlehu / moodle-mod_etherpadlite

This is a moodle plugin for etherpadlite, developed at the Humboldt Universität zu Berlin

20 stars 26 forks source link

readonly url and groupmode fix #52

Closed aczerzuh closed 2 years ago

aczerzuh commented 2 years ago

Fixed an error in the url creation for read only pads and added a check to control if a user is part of a certain group. More details:

The URL generated for a readonly pad is built like .../ro/readonlyid but has to look like .../p/readonly to work.
There is no check if a user is part of a group if hes trying to access a group pad. So he could edit every pad even if hes in a different group within the activity.

grabs commented 2 years ago

Hi Adrian, thanks for your work! This looks good :). But could you provide a single commit for this request and also go through the codechecker? That would be really great. Thanks again! Andreas

aczerzuh commented 2 years ago

Hi Andreas, Thanks for the feedback. I squashed the commits and fixed the missing spaces. Best wishes Adrian

goggo24 commented 2 years ago

Do you already know, when you accept this PR and create a new version? Thanks.

grabs commented 2 years ago

Hi, I am very, very sorry. The last two months I was extremely busy. I hope to get to it in the next few days.

grabs commented 2 years ago

Hi, sorry again for the long duration. Now the fix is included. Many thanks for your work. I appreciate that very much. Best regards Andreas

goggo24 commented 2 years ago

No problem. We are glad the fix is merged, because in our downloadcenter plugin (https://github.com/academic-moodle-cooperation/moodle-local_downloadcenter) we support now etherpad too ;)