search

moodleou / moodle-mod_forumng

ForumNG forum module for Moodle
19 stars 20 forks source link

Missing string in Moodle 2.5 #11

Closed jmvedrine closed 10 years ago

jmvedrine commented 11 years ago

Using forumng master branch with MOODLE_25_STABLE and debugging set to DEVELOPER, I get Invalid get_string() identifier: 'courseuploadlimit' or component 'moodle'. Perhaps you are missing string['courseuploadlimit']=";inlang/en/moodle.php? Most probably because the line $choices[0] = get_string('courseuploadlimit') . ' (' . display_size($COURSE->maxbytes) . ')'; in mod_form.php should be deleted. I know master branch is not ready for Moodle 2.5 so maybe I should no report small warning like that ?

jason-platts commented 11 years ago

Thanks, this is one of the issue we already have recorded so will be fixed soon. It is always worthwhile reporting even small warnings just in case there is something we have missed.

jason-platts commented 10 years ago

This is now fixed in MASTER https://github.com/moodleou/moodle-mod_forumng/commit/ff2f0c7483367cfb9de3b6b2584f3bcae6ada1d4