search

moodleou / moodle-mod_forumng

ForumNG forum module for Moodle
19 stars 20 forks source link

Forumng prevents access to My Home when there are unread discussions #12

Closed markpea closed 10 years ago

markpea commented 10 years ago
  1. Add Forumng activity to course
  2. Post and question and get student responses
  3. Attempt to open My Home to change course. Obtain an error message: Coding error detected, it must be fixed by a programmer: Unread discussion flag not obtained
  4. What it should display is the course name and underneath, "You have ForumNGs that need attention"
  5. This affects anyone who is a student or teacher in the course.

I downloaded the master branch of the moodleou/moodle-mod_forumng from github (https://github.com/moodleou/moodle-mod_forumng) (2013082000) and replaced the forumng code in my sandbox site (moodle 2.5.1) with this. It fixed the problem and the error message did not appear for the same course. So I threw everyone off the production server, put it into maintenance mode and updated the forumng with the new version. All the database updates were successful. Thinking that that sorted the problem I went camping for the weekend. Imagine my surprise when I find that the issue has not been solved and is still present on Monday. More details with screenshots at http://moodle.tiddlyspace.com/#%5b%5bForumNG%20error%5d%5d

Moodle 2.5.1 (20130719) -- and yes, I know that ForumNG is not officially supported but there were reasons for using it -- honest guv -- but now I can't remember what they were :-)

jason-platts commented 10 years ago

Are you able to replicate this issue on a dev server where you can debug? Looking at lib.php (forumng_print_overview) a list of forums should be returned for the user and then the unread status check; it looks like your users are getting the forum object returned but it doesn't have that unread data available for some reason...

Are you using Master/Clone forums (there's a separate code path for those) or are your users restricted from some forums (either targeted for certain groupings or not yet open/or hidden?). These might be some of the things that are causing issues. Note we have disabled My Moodle here so this hasn't really been tested at all...

markpea commented 10 years ago

I've finally sussed the issue. The sandbox server had Track unread posts ticked (Site admin > plugins > Activity modules > ForumNG) whereas the Production server it was unticked. So when unread posts are not tracked the 'Coding error detected' is thrown when users attempts to access My Home, when unread posts are tracked the Forumng displays correctly in My Home. I've replicated this -- just switching 'Track unread posts' off will throw the error, switching back on and there's no error. Hope this helps someone :-) BTW, my users really like ForumNG.

jason-platts commented 10 years ago

Thanks for the info. I've actually fixed this anyway in our local master branch now so that with the Track unread posts unticked you won't get the error.

markpea commented 10 years ago

Brilliant. Thanks. Mark

On 25 September 2013 06:49, Jason Platts notifications@github.com wrote:

Thanks for the info. I've actually fixed this anyway in our local master branch now so that with the Track unread posts unticked you won't get the error.

— Reply to this email directly or view it on GitHubhttps://github.com/moodleou/moodle-mod_forumng/issues/12#issuecomment-25077027 .

Dr Mark H Pearson BSc MSc PhD CDM & bar